Adding z-score metric and fixing test_quantities problem in plot_quantity/pairs_quantity #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests.
|
Contributor
|
Thank you! Looks good. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the posterior z-score as a metric function, since it was already used in the
z_score_contractionplot. This makes it available inpairs_quantityandplot_quantityas well.I also fixed an issue that occurred when defining a custom test quantity and trying to visualize it with
pairs_quantity/plot_quantity. Computing such a quantity sometimes requires attaching extra data to the estimates (e.g. the graph’s adjacency matrix). Previously this raised an error; this is now resolved.